Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check for ManagedMediaSource support #37

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Nov 28, 2023

Adds, optionally, a check for codec support by ManagedMediaSource in browserSupportsCodec().

VHS will not register itself as a source handler unless this returns true. Currently this is a test against MediaSource only. The new optional check allows this to work on new iOS on iPhones, which supports ManagedMediaSource but not MediaSource. The check is optional so that VHS would be able to choose whether to check for support, so playback with ManagedMediaSource can be made optional there, and this also retains backwards compatibility.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88d6e10) 87.54% compared to head (c24d4a3) 87.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   87.54%   87.60%   +0.05%     
==========================================
  Files          18       18              
  Lines        1277     1283       +6     
  Branches      336      342       +6     
==========================================
+ Hits         1118     1124       +6     
  Misses        159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben merged commit 6700c5f into videojs:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants