[sfh][2023] Day 1 (OCaml/Reason) #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-telsan
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Are these esy.lock/ meant to be committed?
There was a problem hiding this comment.
My understanding is that they should be committed (like package-lock.json, but more verbose). The docs on esy.sh mention it here. Also, this starter repo doesn't omit them.
solomonhawk
force-pushed
the
sfh/2023-day1
branch
from
ed8b1eb
to
ba42df4
Compare
solomonhawk
force-pushed
the
sfh/2023-day1
branch
from
ba42df4
to
9375fe9
Compare
dlederle
reviewed
Dec 6, 2023
Comment on lines
+22
to
+36
| let parse = (input: string): t => { | ||
| input | ||
| |> String.trim | ||
| |> String.split_on_char('\n') | ||
| |> List.map(line => | ||
| line | ||
| |> String.to_list | ||
| |> List.map(char => | ||
| switch (char) { | ||
| | '0' .. '9' => N(Char.to_int(char) - Char.to_int('0')) | ||
| | _ => L(char) | ||
| } | ||
| ) | ||
| ); | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://adventofcode.com/2023/day/1
Disclaimer: I absolutely made a complete mess of things here I'm sure. I don't know anything about writing idiomatic/elegant OCaml/Reason.
It feels like they wanted to be extra tricky because they did not explain a key edge case that should be accounted for in solutions.
This diff is a bit noisy since it has all the (one-time) env setup stuff along with the Day 1 solution. Click here if you just want to see the Day 1 solution.
Thoughts
Takeaways
opend some libraries related to sexpr's to get rid ofUnbound module <x>errors in inline tests. This felt confusing, but is mostly just due to lack of familiarity/understanding.opaminstead ofesyas a package manager, butesygrants better sandboxing than rawopamswitches and access to packages published on npm among other things