Article posting #12
Article posting #12
Conversation
… clickable links to them
There was a problem hiding this comment.
Overall, this looks good. There is a bunch of excess stuff that I would scrap because it isn't needed. I think most of that stuff comes from the generators. Fine that you used the generators for this, but going forward, I would skip the generators and just create the new models and stuff yourself, since that will be better for learning purposes. Good that you saw how the generators worked at least once though. Also, going forward, I would try to break up the PRs into smaller, more easily reviewable changes. For example, I would've put the creation of the app into a separate PR from the articles work. There were also some readability things that would be fixed by a formatter in your editor, so I would try to get one of those installed. Otherwise, you just want to basically finish this work by filling out the README and adding some seeds and tests (along with switching from fixtures to factories). Let me know if any of this doesn't make sense to you and you would want to pair on some of it.
Install and run standardrb
…erb. Added seed data for articles.
There was a problem hiding this comment.
This all looks good except for the one note about the cloning instructions in the README, but now that you have tests, I think you should also add a test step to your build workflow so Github Actions will automatically run all the tests for you every time you push.
Made the home page which displays all articles. If you click on an articles title it goes to the link of the article. Clicking on the "comment" button goes to that articles page where comments will be shown once I add them. The add article button goes to a page where you can add an article.