-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show 20 articles #15
Closed
Closed
Show 20 articles #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t so you must be logged in to create articles.
…ates users. Made the author display next to each article on the home page
…pplication.html.erb. Fixed issue with the create article method.
…ted with a user. Added and removed some tests, articles_controller_test still needs work.
…ticles. Changed seeds.rb so 30 articles are created.
…tion in some views.
…t user in application.html.erb. Added edit_email.html.erb since I forgot to add in the last commit.
@paulmckissock Before I can review this, you should change the PR so that it is pointed at the user auth branch instead of main so that way these new changes are distinguished from the old changes from the user auth PR. |
noahko96
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, what I said above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the system only show 20 articles at a time, with the most recent at the top. Used paginate to look at the next set of 20 articles. Changed seeds.rb so it makes 30 sample articles.