Styling #29
Merged
Styling #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… application.html.erb.
noahko96
requested changes
Jul 3, 2024
nathanlong
reviewed
Jul 3, 2024
…s to comments. Replaced many reoccuring inline styles with css classes.
noahko96
approved these changes
Jul 8, 2024
| .comment { | ||
| max-width: 1215px; | ||
| overflow-wrap: anywhere; | ||
| } |
Comment on lines
+74
to
+92
| .comment { | ||
| max-width: 1215px; | ||
| overflow-wrap: anywhere; | ||
| } | ||
| .post-subtext { | ||
| height:5px; | ||
| } | ||
| .header-space { | ||
| height:10px | ||
| } | ||
| .page-table { | ||
| border:0; | ||
| border-collapse: collapse; | ||
| } | ||
| .page-table td, | ||
| .page-table th { | ||
| padding: 0; | ||
| } | ||
| .paginate-spacing { |
There was a problem hiding this comment.
I would put line breaks between all of these blocks to clean them up.
| if comment.replies.any? | ||
| concat(content_tag(:ul) do | ||
| concat(content_tag(:ul, style: "padding-left: 20px;") do |
There was a problem hiding this comment.
I would replace this with a class instead of the inline styling.
| <div><%= message %></div> | ||
| <% end %> | ||
| </div> | ||
| <%= form_with model: @article do |form| %> |
There was a problem hiding this comment.
Since you made article a helper method, I would use it here instead of @article.
| <tr class="header-space"></tr> | ||
| <tr> | ||
| <td colspan="3"> | ||
| <%= form_with(model: [@article, @comment], local: true) do |form| %> |
There was a problem hiding this comment.
Would also use the helper method here.
| </tr> | ||
| <tr> | ||
| <td colspan="3"> | ||
| <ul style="list-style-type: none; padding-left: 0;"> |
There was a problem hiding this comment.
Some more inline styling I would replace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styled article pages, comment pages, user pages, login page, signup page, reset password, user article pages, and new article page.