Upgrade jsdom to fix test errors #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm test` failed with error text like this: ``` Error: The module 'node_modules/canvas/build/Release/canvas.node' was compiled against a different Node.js version using NODE_MODULE_VERSION 93. This version of Node.js requires NODE_MODULE_VERSION 108. canvas was compiled against a different Node.js version ``` Version 93 is a v16 release, but the project version is on 18 now. A `uninstall` and a new `install -D` got the jsdom tests working.
✅ Deploy Preview for react-ts-reference-2022 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Coverage after merging fix-jsdom into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
solomonhawk
approved these changes
Sep 21, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | https://650c71ceeecbcc0008c7af8e--react-ts-reference-2022.netlify.app |
| Device | URL |
|---|---|
| mobile | https://650c71ceeecbcc0008c7af8e--react-ts-reference-2022.netlify.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm testfailed with error text like this:Version 93 is a v16 release, but the project version is on 18 now. A
uninstalland a newinstall -Dgot the jsdom tests working.