-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☕ separate check:doc
task
#259
Conversation
WalkthroughThis update enhances a Deno project's CI/CD workflow by introducing a "Doc check" step to validate documentation alongside existing code checks. Additionally, it refines task definitions in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/test.yml (1 hunks)
- deno.jsonc (1 hunks)
Additional comments not posted (2)
.github/workflows/test.yml (1)
55-56
: Addition of "Doc check" step is appropriate.The new "Doc check" step enhances the CI/CD workflow by ensuring documentation quality. Its placement between "Type check" and "Gen check" is logical and maintains a clear workflow.
deno.jsonc (1)
84-85
: Task separation enhances clarity and usability.The introduction of the
check:doc
task and the modification of thetest
task improve the separation of concerns, allowing documentation checks to be run independently from tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 57 57
Lines 2979 2979
Branches 251 251
=======================================
Hits 2461 2461
Misses 516 516
Partials 2 2 ☔ View full report in Codecov by Sentry. |
deno test --doc
vsdeno test --watch
is conflicts.Now can
deno task test --watch
.Summary by CodeRabbit
New Features
Improvements