pflag: add integral-slice and uintptr support #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
Jan 29, 2024
silvenac
approved these changes
Jan 29, 2024
Mirroring the flag support, add support for integral-typed flags. Also, fix a bug in the pflag vistor callback that paniced due to an incorrect conversion. (exercised via the new the uintptr support)
dfinkel
force-pushed
the
flag_integral_type_slice_support
branch
from
852a1cf
to
ba90168
Compare
dfinkel
force-pushed
the
integral_type_slice_pflags
branch
from
4f24296
to
7b6fcff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the flag support, add support for integral-typed flags.
Also, fix a bug in the pflag vistor callback that paniced due to an
incorrect conversion. (exercised via the new the uintptr support)