flags/pflags: slice/map flags concat/merge & README update #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
Jun 7, 2024
README.md
Outdated
| if dialsErr != nil { | ||
| // error handling | ||
| } | ||
|
|
||
| // Fill will deep copy the fully-stacked configuration into its argument. | ||
| // View returns a pointer to the fully stacked configuration file | ||
| // The stacked configuration is populated from the config file, environment | ||
| // variables and commandline flags. Can alternatively use |
There was a problem hiding this comment.
nit: dangling sentence here...
There was a problem hiding this comment.
I knew I saw that fragment someplace, but lost track of it 🙁
Removed.
README.md
Outdated
| As a result, a commandline with `"--a=b", "--a=c"` may be parsed as `[]string{b,c}`. | ||
|
|
||
| #### Maps | ||
| Maps are parsed like Slices, with the addition of `:` separators between keys and values. ([`strconv.Unquote`](https://pkg.go.dev/strconv#Unquote)-compatible quoting is mandatory for more complicated strins as well) |
There was a problem hiding this comment.
nit:
Suggested change
| Maps are parsed like Slices, with the addition of `:` separators between keys and values. ([`strconv.Unquote`](https://pkg.go.dev/strconv#Unquote)-compatible quoting is mandatory for more complicated strins as well) | |
| Maps are parsed like Slices, with the addition of `:` separators between keys and values. ([`strconv.Unquote`](https://pkg.go.dev/strconv#Unquote)-compatible quoting is mandatory for more complicated strings as well) |
README.md
Outdated
| } | ||
| conf, serial := d.ViewVersion() | ||
|
|
||
| // you can get notified whenever the config changes by registering a callback |
There was a problem hiding this comment.
nit: extra indentation
Suggested change
| // you can get notified whenever the config changes by registering a callback | |
| // You can get notified whenever the config changes by registering a callback. |
There was a problem hiding this comment.
Fixed the capitalization.
It was actually worse than extra indentation. Somehow, I ended up with spaces instead of tabs, and a tabstop of 4 for some of the new lines. I've fixed that.
It's been a while since it was last updated, and I felt weird adding a section explaining slice parsing without fixing the complete staleness of the readme's examples. - Removed Fill() calls, which are deprecated - Updated ez package references to use Params - Removed type-asserts on View() calls - Removed Events() calls, and updated to the less convoluted callback-based change-notification mechanism.
Instead of always using the last flag value referenced, merge all values present.
dfinkel
force-pushed
the
multiple_flags_concat_slices_merge_maps
branch
from
50a0e2b
to
839367a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README
It's been a while since it was last updated, and I felt weird adding a
section explaining slice parsing without fixing the complete staleness
of the readme's examples.
callback-based change-notification mechanism.
flags/pflags: slice/map flags concat/merge
Instead of always using the last flag value referenced, merge all values
present.