Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update django template command in README.md to include docker-compose #605

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Update django template command in README.md to include docker-compose #605

merged 3 commits into from
Aug 3, 2023

Conversation

hugobessa
Copy link
Contributor

@hugobessa hugobessa commented Jul 31, 2023 •
edited
Loading

fixes #604

Description

Motivation and Context

Screenshots (if appropriate):

Steps to reproduce (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires documentation updates.
  • I have updated the documentation accordingly.
  • My change requires dependencies updates.
  • I have updated the dependencies accordingly.

@hugobessa hugobessa mentioned this pull request Jul 31, 2023
Closed
@fjsj
Copy link
Member

fjsj commented Aug 1, 2023

Is this ready to merge?

@fjsj fjsj self-requested a review August 1, 2023 18:52
@hugobessa hugobessa merged commit be60adf into master Aug 3, 2023
2 checks passed
@hugobessa hugobessa deleted the fix-django-template-command branch August 3, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjsj fjsj fjsj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running make docker_setup returns error with current version of docker-compose.yaml
2 participants
@hugobessa @fjsj