Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/upgrade pre-commit config #74

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix/upgrade pre-commit config #74

merged 1 commit into from
May 21, 2024

Conversation

pamella
Copy link
Contributor

@pamella pamella commented May 20, 2024

Description: Describe in a couple of sentence what this PR adds

Fix/upgrade pre-commit config since it wasn't working.

Dependencies: dependencies on other outstanding PRs, issues, etc.

N/A

Merge deadline: List merge deadline (if any)

N/A

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  • Run pre-commit install
  • Check if the steps work properly.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • PR author is listed in AUTHORS

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@pamella pamella requested a review from fjsj May 20, 2024 20:41
@pamella pamella merged commit 5c5358c into main May 21, 2024
25 checks passed
@pamella pamella deleted the fix/pre-commit branch May 21, 2024 12:59
@pamella pamella mentioned this pull request May 27, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants