Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Django versions that have reached end of life #75

Merged
merged 5 commits into from
May 22, 2024

Conversation

pamella
Copy link
Contributor

@pamella pamella commented May 22, 2024

Description: Describe in a couple of sentence what this PR adds

Dependencies: dependencies on other outstanding PRs, issues, etc.

N/A

Merge deadline: List merge deadline (if any)

N/A

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  • Tests should be running properly on GH actions.
Screencast.from.22-05-2024.16.14.07.webm

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • PR author is listed in AUTHORS

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename to tests.
  • Now runs on every push and PR.

@@ -49,7 +49,6 @@ upgrade: ## update the requirements/*.txt files with the latest packages satisfy
pip-compile --upgrade -o requirements/doc.txt requirements/base.in requirements/doc.in
pip-compile --upgrade -o requirements/quality.txt requirements/quality.in
pip-compile --upgrade -o requirements/test.txt requirements/base.in requirements/test.in
pip-compile --upgrade -o requirements/travis.txt requirements/travis.in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix.

@pamella pamella requested a review from fjsj May 22, 2024 19:17
@pamella pamella added bug Something isn't working dependencies Pull requests that update a dependency file labels May 22, 2024
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pamella pamella merged commit ef6ebd9 into main May 22, 2024
10 checks passed
@pamella pamella deleted the fix/drf-version-support branch May 22, 2024 21:10
@pamella pamella mentioned this pull request May 27, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants