-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pip-tools
with poetry
#78
Conversation
@@ -41,6 +41,7 @@ def get_version(*file_paths): | |||
"Framework ones adding separated serializers for read and write operations" | |||
), | |||
long_description=README + "\n\n" + CHANGELOG, | |||
long_description_content_type="text/x-rst", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by warning fix.
.ruff.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content moved to pyproject.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, but please check comments
Description: Describe in a couple of sentence what this PR adds
pip-tools
withpoetry
Dependencies: dependencies on other outstanding PRs, issues, etc.
It could be better to merge this PR once #77 is merged, just in case of code conflicts.
Merge deadline: List merge deadline (if any)
N/A
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.