Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pip-tools with poetry #78

Merged
merged 9 commits into from
May 27, 2024
Merged

Replace pip-tools with poetry #78

merged 9 commits into from
May 27, 2024

Conversation

pamella
Copy link
Contributor

@pamella pamella commented May 27, 2024

Description: Describe in a couple of sentence what this PR adds

  • Replace pip-tools with poetry
    • Remove no longer used files and dependencies
    • Update existing make commands
    • Updating tox config

Dependencies: dependencies on other outstanding PRs, issues, etc.

It could be better to merge this PR once #77 is merged, just in case of code conflicts.

Merge deadline: List merge deadline (if any)

N/A

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  • All make commands should be working.
  • CI action should be working.
  • Tests should be running and passing.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • PR author is listed in AUTHORS

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@@ -41,6 +41,7 @@ def get_version(*file_paths):
"Framework ones adding separated serializers for read and write operations"
),
long_description=README + "\n\n" + CHANGELOG,
long_description_content_type="text/x-rst",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by warning fix.

.ruff.toml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content moved to pyproject.toml.

@pamella pamella requested a review from fjsj May 27, 2024 13:32
.gitignore Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, but please check comments

@pamella pamella requested review from hugobessa and fjsj May 27, 2024 13:59
@pamella pamella merged commit 2a339b7 into main May 27, 2024
10 checks passed
@pamella pamella deleted the feat/poetry branch May 27, 2024 14:54
@pamella pamella mentioned this pull request May 27, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants