Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selection of files via clicking the input #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow selection of files via clicking the input #2

wants to merge 2 commits into from

Conversation

morelazers
Copy link

Otherwise requires user to drag the file.

vipero07
vipero07 reviewed Jun 29, 2020
View reviewed changes
Copy link
Owner

@vipero07 vipero07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the point of this is, it already handles clicking the input for file selection that's the point of the on:input line.

The change also introduces a naming collision on line 24 with line 11

@morelazers
Copy link
Author

morelazers commented Jun 30, 2020 •
edited
Loading

It wasn't working for me in Safari /shrug - happy for you to close it

@vipero07 vipero07 added the bug Something isn't working label Aug 11, 2020
@vipero07
Copy link
Owner

I'm going to have to look into safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipero07 vipero07 vipero07 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morelazers @vipero07