New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed new glob async behaviour #463

Merged

rayman2000 merged 9 commits into master from fix-glob

Feb 4, 2025

Contributor

rayman2000 commented Aug 28, 2024 •

edited

Loading

This PR provides two fixes:

Glob now is async by default, so we do not need to wrap it in a Promise. This has been blocking updates for some time now.
The order we execute the tests needs to be correct, for some reason they are currently be executed in flipped order.

It also fixes the vscode launch.json for running the tests out of vscode directly.

rayman2000 and others added 8 commits

August 28, 2024 16:37


          Fixed glob?

0562d69


          Bump the all group across 1 directory with 10 updates

5839bf4

Bumps the all group with 10 updates in the /client directory:

| Package | From | To |
| --- | --- | --- |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.5.1` | `22.8.6` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.3.0` | `8.12.2` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `8.3.0` | `8.12.2` |
| [@vscode/vsce](https://github.com/Microsoft/vsce) | `2.26.0` | `3.2.1` |
| [eslint](https://github.com/eslint/eslint) | `9.8.0` | `9.13.0` |
| [mocha](https://github.com/mochajs/mocha) | `10.7.3` | `10.8.2` |
| [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) | `10.0.7` | `10.0.9` |
| [typescript](https://github.com/microsoft/TypeScript) | `5.5.4` | `5.6.3` |
| [vs-verification-toolbox](https://github.com/viperproject/vs-verification-toolbox) | ``bd9e005`` | ``cb59d87`` |
| [webpack](https://github.com/webpack/webpack) | `5.94.0` | `5.96.0` |



Updates `@types/node` from 22.5.1 to 22.8.6
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@typescript-eslint/eslint-plugin` from 8.3.0 to 8.12.2
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.12.2/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.3.0 to 8.12.2
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.12.2/packages/parser)

Updates `@vscode/vsce` from 2.26.0 to 3.2.1
- [Release notes](https://github.com/Microsoft/vsce/releases)
- [Commits](microsoft/vscode-vsce@v2.26.0...v3.2.1)

Updates `eslint` from 9.8.0 to 9.13.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.8.0...v9.13.0)

Updates `mocha` from 10.7.3 to 10.8.2
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v10.7.3...v10.8.2)

Updates `@types/mocha` from 10.0.7 to 10.0.9
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha)

Updates `typescript` from 5.5.4 to 5.6.3
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.5.4...v5.6.3)

Updates `vs-verification-toolbox` from `bd9e005` to `cb59d87`
- [Commits](viperproject/vs-verification-toolbox@bd9e005...cb59d87)

Updates `webpack` from 5.94.0 to 5.96.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.94.0...v5.96.0)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@vscode/vsce"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@types/mocha"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: vs-verification-toolbox
  dependency-type: direct:development
  dependency-group: all
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
...

Signed-off-by: dependabot[bot] <[email protected]>


          tried to fix tests

acc2871


          Merge branch 'dependabot/npm_and_yarn/client/all-d04598f6d4' into fix…

66d6a49

…-glob


          Merge remote-tracking branch 'origin/master' into fix-glob

30cc899


          updates

d10769d


          disabled process check for now

26b9e54


          reactivated process check

6115c1a

rayman2000 changed the title ~~Fixed glob?~~ Fixed new glob async behaviour

rayman2000 requested a review from ArquintL

February 3, 2025 14:14

ArquintL approved these changes

View reviewed changes

Member

ArquintL left a comment

Only a minor comment about documenting why we reverse the files (or at least capture your observations as I guess the true reason is unknown)

client/src/test/index.ts Outdated

                   const filenames = await getTestSuiteFilenames();
-                  filenames.forEach(filename => mocha.addFile(path.resolve(TESTS_ROOT, filename)));
+                  filenames.reverse().forEach(filename => mocha.addFile(path.resolve(TESTS_ROOT, filename)));

Member

ArquintL Feb 3, 2025

Please add a comment why we do this


          sort instead of reverse

1a1e849

rayman2000 merged commit 4785dc2 into master

10 checks passed

rayman2000 deleted the fix-glob branch

February 4, 2025 10:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet