Skip authorization if in development/testing

[ShakyaMajumdar]

Closes #47

[Robin5605]

[Robin5605]

For the tests failing - I think they should be fixed by moving the check inside get_access_token, like so:

def get_access_token(*, http_client: Client) -> str:
    """Get an access token from Auth0."""

+    if SKIP_AUTH:
+        return "DEVELOPMENT"

    payload = {
        "client_id": Settings.client_id,
        "client_secret": Settings.client_secret,
        "username": Settings.username,
        "password": Settings.password,
        "audience": Settings.audience,
        "grant_type": "password",
    }

    res = http_client.post(f"https://{Settings.auth0_domain}/oauth/token", json=payload)
    res.raise_for_status()
    json = res.json()
    return json["access_token"]  # type: ignore[no-any-return]

Because currently, the tests except the access token in the request to be whatever is returned by get_access_token (and reasonably so), however we are overriding it elsewhere which makes the expected mock calls to fail.

[ShakyaMajumdar]

That would case test_get_access_token to fail instead because it expects get_access_token to always make a http request to the auth url

[Robin5605]

That would case test_get_access_token to fail instead because it expects get_access_token to always make a http request to the auth url

Hmm, yeah, you're right. I think it would be best to have 2 tests for test_get_access_token then, one that ensures that it makes a request when GIT_SHA is something real, and one that ensures it doesn't make a request (when GIT_SHA is set to testing)

[jonathan-d-zhang]

forgor to submit this