Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: format using prettier #27

Merged
merged 1 commit into from
Sep 2, 2023
Merged

style: format using prettier #27

merged 1 commit into from
Sep 2, 2023

Conversation

sid-maddy
Copy link
Contributor

No description provided.

@sid-maddy sid-maddy self-assigned this Sep 2, 2023
@sid-maddy
Copy link
Contributor Author

CI will pass after #26 is merged.

@sid-maddy
style: format using prettier
2021045 
Signed-off-by: Siddhesh Mhadnak <[email protected]>
import-pandas-as-numpy
import-pandas-as-numpy approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@import-pandas-as-numpy import-pandas-as-numpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure I care for how opinionated Prettier is on markdown formatting.

@sid-maddy
Copy link
Contributor Author

FWIW, prettier is what's configured in the format script in package.json.
I just ran npm run format ¯_(ツ)_/¯

@sid-maddy sid-maddy merged commit d109400 into main Sep 2, 2023
5 checks passed
@sid-maddy sid-maddy deleted the sid/style/format branch September 2, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-pandas-as-numpy import-pandas-as-numpy import-pandas-as-numpy approved these changes

Assignees

@sid-maddy sid-maddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sid-maddy @import-pandas-as-numpy