Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for string element queries based on attributes #411

Merged
merged 29 commits into from
Oct 23, 2024

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #17

Give a longer description of what this PR addresses and why it's needed

In Element View:

  • Changes the top-level header 'Element Queries' to 'Bookmarked Queries'
  • Adds a new 'Element Queries' section containing a form with 3 fields:
    • Attribute Name (dropdown), to select the attribute being queried for
    • Query Type (dropdown), allowing selection between equals, contains, length equals, regex, less than, and greater than.
    • Query (string input), for the query string to match the attribute with based on the type
  • Implements element queries similarly to backselection; they cause selection bars in the plot, filter the Query Result table, and show up as bookmarkable under Bookmarked Queries

Pictures/videos of the behavior before and after these changes

No before (the interface shown simply didn't exist)
After:
query-after

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed
  • Where is this?

@NateLanza NateLanza self-assigned this Oct 21, 2024
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit d27a871
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/67196861ab42b60008d22d0c
😎 Deploy Preview https://deploy-preview-411--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/core/src/typecheck.ts Outdated Show resolved Hide resolved
packages/core/src/utils.ts Outdated Show resolved Hide resolved
@NateLanza NateLanza merged commit 9479420 into main Oct 23, 2024
7 checks passed
@NateLanza NateLanza deleted the 17-query-interface branch October 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Query Interface
2 participants