Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in LTRTrainer._update_stats(). #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix memory leak in LTRTrainer._update_stats(). #313

wants to merge 1 commit into from

Conversation

Capricorn231
Copy link

The method _update_stats() is called with val, which is a Tensor with gradients. When use with AverageMeter, the gradient graph will be accumulated during training and won't be released and collected by GC, causing significant memory leak.

@martin-danelljan
Copy link
Contributor

val is not necessarily always a tensor. So we need to have a check if its actually a tensor first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Capricorn231 @martin-danelljan