Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Apply PixelRatio.roundToNearestPixel() to all calculated values based on REM.
Motivation
I am using float values for basic
$rem
. So calculated values could be float too and sometimes it's producing issues like thatExample:
To fix this I should round each value to nearest pixel via PixelRatio.roundToNearestPixel(). Otherwise it produces bug like on picture above.