Fixing bugs for select2 editable #1015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
select2 for <input type="hidden"> is depracated and not working correctly for many features...
value2input was not working at all for me in a multiple select2 setup. No value showed in select2 control after opening xeditable bubble. Firstly, why change the array of values to a joined string? Select2 accepts array as input for multiple/tagged select2, so join should be removed. Secondly, since the select2 data are created with js during select2 initialization (no option tags exist in select tag in template), when setting the select value before initializing select2 nothing happens and the value always remains null (which was my problem). So I initialized the select2 if not already initialized and then I set the select2 value. Now it works for me.
Changed the order of the fired event and the call to activating the control. Before thew select2 was activated and after the select2 dropdown was rendered the popover was repositioned when the show event was fired. However the select2 dropdown position remained unchanged and the end placement was wrong. With this fix the show event is fired (positioning the popover) before the callback to activating the element (that shows and positions the select2 dropdown)
|
hello, there is some problems with your changes (i think, but perhaps it's before) when running grunt : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xeditable was not working properly for me for select2 inputs. No value showed in select2 control after opening xeditable bubble.
I edited your final version to work for me properly.
I also changed the tpl for select2 to as the first one is depracated in the select2 docs and some select2 options were not working for me as expected for the input tag.