Add support for Bootstrap4 #1071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubicek
added a commit
to kubicek/x-editable-rails
that referenced
this pull request
Jan 17, 2018
with libs from vitalets/x-editable#1071
|
Was support for the datepicker added? |
|
I did not test by myself (and test units are kind of broken in general), but it's likely that it works - as well as it did for bs3. |
|
Datepickers are not implemented for bootstrap3 (for some reason), maybe now is a good time to bridge the gap? Combodates are really aesthetically unpleasing. |
|
Any news on this? 😄 It needs some more tweaks. Bootstrap 4 is using Popper.js instead of Tether. The Popover position is right by default and should be top? |
|
For those of you who are struggling to implement it on Bootstrap 4, maybe this can help. For Bootstrap 4 its work, check this #1189 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the test-suite working in cli for bs4. Tested via browser.
[common] 8. container's title and placement from json optionsfailed because css for bootstrap is not being loaded for some reason.Other than that it's alright. Some units related to datepicker and select2 failing, but they fail for bs3 aswell, so.. ¯_(ツ)_/¯.
#1043 #950