Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): ensure HMR updates styles when SFC is treated as a type dependency #541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jh-leong
Copy link
Contributor

@jh-leong jh-leong commented Mar 8, 2025

Description

close vuejs/core#13008

Fix HMR when an SFC exporting a type is treated as a type dependency. Ensure the SFC itself triggers an update instead of relying only on type dependency handling, preventing outdated transforms from applying and causing incorrect updates.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented Mar 8, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@541
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@541

commit: 9c74982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<style> HMR require save twice when exporting a type from a component
1 participant