Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: path resolve edge #19486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: path resolve edge #19486

wants to merge 1 commit into from

Conversation

OnlyWick
Copy link
Contributor

Description

close #19406.

path.posix.normalize also has issues with path resolution errors, so it also needs to be fixed.

@OnlyWick
Copy link
Contributor Author

Rerunning the CI, tests will pass

@OnlyWick
Copy link
Contributor Author

This is NOT just a relative path issue; this problem occurs with all uses of path.resolve. Perhaps we need to encapsulate path.resolve to avoid these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

./x.js?foo=/../y.js is resolved as ./y.js instead of ./x.js
1 participant
@OnlyWick