Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(importAnalysis): skip merging accepted urls #19558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OnlyWick
Copy link
Contributor

@OnlyWick OnlyWick commented Mar 3, 2025

Description

Some modules do not have HMR. If the execution of mergeAcceptedUrls is not skipped, it will cause 2 * imports.length unnecessary loops.

const orderedAcceptedUrls = new Array<Set<UrlPosition> | undefined>(
imports.length,
)
const orderedAcceptedExports = new Array<Set<string> | undefined>(
imports.length,
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant