fix: validate websocket request #7317
Open
+103
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: shouldHandle cannot be async wip: copy isHostAllowed chore: move code chore: comment wip: allow only same origin chore: cleanup wip: isApiRequestAllowed chore: cleanup wip: switch to token check chore: unused fix: inject VITEST_API_TOKEN in orchestrator ui docs: add api.allowedHosts fix: require token for __vitest_browser_api__ request chore: cleanup refactor: combine to isWebsocketRequestAllowed
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jan 21, 2025
sapphi-red
approved these changes
Jan 21, 2025
AriPerkkio
previously approved these changes
Jan 21, 2025
There was a problem hiding this comment.
The token protection looks good to me.
The allowedHosts part is something I don't really understand. The WS endpoints will still be responding to any client that has the token. We are not passing allowedHosts anywhere else, so users still won't be able to open Vitest UI or browser from these. I don't understand why allowedHosts is needed here.
Co-authored-by: Ari Perkkiö <[email protected]>
This reverts commit 7f91828.
AriPerkkio
approved these changes
Jan 22, 2025
sapphi-red
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
summary
Adds
?token=xxxrequirement for websocket upgrade request on__vitest__api__and__vitest_browser_api__. Token is randomly generated on the server and it's injected in ui, tester, and orchestrator html, which are not accessible from cross origin.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.