fix: ensure project names are readable in dark terminals #7371
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In terminals using a color scheme with a dark background, project names could end up being unreadable because one of the hard-coded background colors used for project names was black. Replacing black with blue solves this problem while also ensuring that project names remain readable in terminals with light backgrounds.
This mitigates an issue that's described in the comments of #6481, although it doesn't implement fully customizable colors, which is the main topic of that issue.
After:
Before:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
There doesn't seem to be any existing test coverage for the colors defined in
formatProjectName()
. It's not immediately obvious to me how I might add coverage, so pointers are welcome!pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.There's one pre-existing test failure that also occurs on
main
. It's unrelated to this change:Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.