Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): fix webdriverio switchToFrame deprecation notice #7497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

feryardiant
Copy link

Description

Just recently my curiousity drove me to try run browser test using webdriverio and I expect everything should work the same as when I use playwright, right? then I did feryardiant/poc-brackets#31

In my ci I saw bunch of [WEBDRIVERIO DEPRECATION NOTICE] as described #6804

⚠️ [WEBDRIVERIO DEPRECATION NOTICE] The "switchToFrame" command is deprecated and we encourage everyone to use `switchFrame` instead for switching into frames. Read more about this command at https://webdriver.io/docs/api/browser/switchFrame.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Unfortunately I'm unable to link my fork to see it on github actions since vitest is monorepo and as my understanding using github url as dependency only work on root package.json in npm.

npm error code 1
npm error git dep preparation failed
npm error command /opt/homebrew/Cellar/node/23.7.0/bin/node /opt/homebrew/lib/node_modules/npm/bin/npm-cli.js install --force --cache=~/.npm --prefer-offline=fa
lse --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm error npm warn using --force Recommended protections disabled.
npm error npm error code EUNSUPPORTEDPROTOCOL
npm error npm error Unsupported URL Type "workspace:": workspace:*
npm error npm error A complete log of this run can be found in: ~/.npm/_logs/2025-02-14T14_30_09_058Z-debug-0.log
npm error A complete log of this run can be found in: ~/.npm/_logs/2025-02-14T14_28_51_970Z-debug-0.log

All I can do for now is link it with my local clone as suggested in the contribution guideline

{
  // ...
  "devDependencies": {
    // ...
    "@vitest/browser": "file:~/path/to/vitest/packages/browser",
    // ...
  },
}

I'll figure out another workaround later.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c5eebde
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67af5e7e4f6e790008b23a9c
😎 Deploy Preview https://deploy-preview-7497--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@feryardiant
Copy link
Author

Well, just realized that vitest still runs on webdriverio v8 instead of v9, I'd assume that the team is already aware of this and that's why its yet to be upgrade to v9.

feryardiant added a commit to feryardiant/poc-brackets that referenced this pull request Feb 14, 2025
@hi-ogawa
Copy link
Contributor

Well, just realized that vitest still runs on webdriverio v8 instead of v9, I'd assume that the team is already aware of this and that's why its yet to be upgrade to v9.

Yes, I haven't looked into properly, but there might be some issues with v9. Renovate auto-update PR is in #6398 and at least our CI is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants