Add notification for deployment completion #445
Merged
+65
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add notification for deployment completion status. * Create `DeploymentCompleted` notification class in `app/Notifications/DeploymentCompleted.php` to handle deployment completion notifications. * Update `app/Actions/Site/Deploy.php` to send `DeploymentCompleted` notification using `Notifier` when a deployment completes or fails. * Import `Notifier` and `DeploymentCompleted` classes in `app/Actions/Site/Deploy.php`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vitodeploy/vito?shareId=XXXX-XXXX-XXXX-XXXX).
|
Looking good! Can you please write a test for it? |
|
|
I will add one more test to cover it E2E. ideally on the deploy test, I would expect the notification has been sent vito/tests/Feature/ApplicationTest.php Line 54 in 7b723bc |
|
Added the test. also deleted the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notification for deployment completion status.
DeploymentCompletednotification class inapp/Notifications/DeploymentCompleted.phpto handle deployment completion notifications.app/Actions/Site/Deploy.phpto sendDeploymentCompletednotification usingNotifierwhen a deployment completes or fails.NotifierandDeploymentCompletedclasses inapp/Actions/Site/Deploy.php.For more details, open the Copilot Workspace session.