refactor: __build_app function clean-up and make all modules accessible
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible This is both a refactor and a fix for the `Modulename.html = True` default that was removed with viur-core 3.6. The error `AttributeError: 'Index' object has no attribute '<modulename>'` is fixed with this improvement, and the workaround of `conf.main_app.vi.modulename` is not neccessary anymore.
phorward
added
bug(fix)
|
We think about putting this into main branch v3.6 |
|
Replaced by #1240 |
phorward
added a commit
that referenced
this pull request
Aug 21, 2024
…ible (#1240) This is both a refactor and a fix for the `Modulename.html = True` default that was removed with viur-core 3.6. The error `AttributeError: 'Index' object has no attribute '<modulename>'` is fixed with this improvement, and the workaround of `conf.main_app.vi.modulename` is not neccessary anymore. Belongs to #1229, replaces #1232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is both a refactor and a fix for the
Modulename.html = Truedefault that was removed with viur-core 3.6.The error
AttributeError: 'Index' object has no attribute '<modulename>'is fixed with this improvement, and the workaround ofconf.main_app.vi.modulenameis not neccessary anymore.Belongs to #1229.