fix: skip cached_property in Module._update_methods
#1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speed the boot since the `cached_property` will not be calculated during boot, but lazy when it's needed And if you return a callable exposed via the cached_property you are crazy
sveneberth
added
bug(fix)
sveneberth
changed the title
Module.cached_property in _update_methodsModule.cached_property in _update_methods
sveneberth
changed the title
Module.cached_property in _update_methodscached_property in Module._update_methods
phorward
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the boot, since the
cached_propertyisn't calculated during the boot, but lazily when it's needed.And if you return a callable exposed via the cached_property you are just crazy 🙈