Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated file loading so that embedded directories are supported. #420

Draft
wants to merge 2 commits into
base: dynapi-1.14
Choose a base branch
from

Conversation

ivanmrsulja
Copy link
Member

@ivanmrsulja ivanmrsulja commented Sep 22, 2023

What does this pull request do?

Enables loading RDF files from sub-directories, so that .n3 template refactoring can be implemented by using packages. Loading subdirectories only works in the case of everytime files, so that file graph loading won't be affected (they are implemented with different loading logic in mind).

What's new?

Changed RDFFilesLoader class (getPaths method) so that it supports loading files from sub-directories using visitor pattern. As mentioned above, this loading method only works if the loading directory is named "everytime", indicating that it contains dynapi .n3 templates.

How should this be tested?

Startup VIVO dynapi. You should include some .n3 templates that are split in (ideally with hierarchy > 1) packages, you can find few examples here. After startup, RDF files from sub-directories should be loaded and all functionality should be available to you whether through swagger documentation or some client mocking tool (eg. Postman, cURL...).

Interested parties

@litvinovg @chenejac @brianjlowe

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanmrsulja looks good to me. Thanks

@chenejac chenejac marked this pull request as draft November 2, 2023 15:31
@chenejac chenejac changed the base branch from dynapi-1.14 to dynapi-1.14.1-snapshot June 4, 2024 09:53
@chenejac chenejac changed the base branch from dynapi-1.14.1-snapshot to dynapi-1.14 June 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants