Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Qtip Library with Floating ui #439

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

milospp
Copy link
Contributor

@milospp milospp commented Jan 30, 2024

VIVO GitHub issue: 3931
Linked VIVO PR

What does this pull request do?

This pull request focuses on the removal of the Qtip library from the project, substituting it with Floating ui Library. The design has been configured to maintain similarity with the previous implementation using Qtip.

Only the Vitro part of PR is mandatory for the popper to work, other changes in Vitro and VIVO PR are only to initiate tooltip and style it.

What's new?

The Popper tooltip automatically identifies available screen space for display.

Before:

image image image image

After:

Individual Search resultd download MapOfScience

How should this be tested?

On the Individual profile page:

  • Hover, Research area icon image (#researchAreaIcon)
  • Click, Contanct Info link icon image (#uriIcon)

On the Search results page:

  • Click, download icon image (#downloadIcon)

On the MapOfScience page:

  • Hover over next elements, #mageIconOne, #exploreInfoIcon, #compareInfoIcon, #imageIconThree

Additional Notes:

  • This pull request may impact dependencies, as it involves the removal of the Qtip library and the addition of Popper. Please be mindful of potential issues in this regard.

Interested parties

@VIVO-project/vivo-committers

Copy link
Member

@gneissone gneissone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review vivo-project/VIVO#3937 (review) for general remarks.

These changes work well with Wilma, but do not work with the default vitro template since vitro does not include bootstrap. Wonder if the tooltips can just be dropped completely in the vitro template, since it was intended to be minimal in the first place...

@chenejac chenejac requested a review from gneissone February 13, 2024 09:32
@chenejac chenejac marked this pull request as draft April 12, 2024 11:05
@milospp milospp marked this pull request as ready for review November 20, 2024 00:30
@milospp milospp force-pushed the fix-tooltip branch 2 times, most recently from 51646ef to ddddae7 Compare December 8, 2024 22:21
@milospp milospp changed the title Replace Qtip Library with Bootstrap Tooltip Replace Qtip Library with Popper Dec 10, 2024
@milospp milospp changed the title Replace Qtip Library with Popper Replace Qtip Library with Floating ui Dec 11, 2024
@chenejac chenejac requested a review from litvinovg December 23, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace qtip dependency
2 participants