-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Qtip Library with Floating ui #439
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see review vivo-project/VIVO#3937 (review) for general remarks.
These changes work well with Wilma, but do not work with the default vitro template since vitro does not include bootstrap. Wonder if the tooltips can just be dropped completely in the vitro template, since it was intended to be minimal in the first place...
51646ef
to
ddddae7
Compare
VIVO GitHub issue: 3931
Linked VIVO PR
What does this pull request do?
This pull request focuses on the removal of the Qtip library from the project, substituting it with Floating ui Library. The design has been configured to maintain similarity with the previous implementation using Qtip.
Only the Vitro part of PR is mandatory for the popper to work, other changes in Vitro and VIVO PR are only to initiate tooltip and style it.
What's new?
The Popper tooltip automatically identifies available screen space for display.
Before:
After:
How should this be tested?
On the Individual profile page:
On the Search results page:
On the MapOfScience page:
Additional Notes:
Interested parties
@VIVO-project/vivo-committers