Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap5 dependency #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Contributor

What does this pull request do?

Added Boostrap 5 webjar dependency. Only the last commit related to this PR.

How should this be tested?

Build Vitro and VIVO

Interested parties

@milospp @chenejac

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Maven

Reviewers' report template

Please update the following template which should be used by reviewers.

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@litvinovg litvinovg requested review from chenejac and milospp May 24, 2024 13:25
@litvinovg litvinovg force-pushed the bootstrap5-dependency branch from f7e07e3 to 9605af0 Compare May 31, 2024 11:37
Copy link
Contributor

@milospp milospp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@milospp
Copy link
Contributor

milospp commented Jun 5, 2024

Just to note, I tried to add multiple versions of Bootstrap to the project by duplicating the section, and changing the and elements.

Like this:

                                <artifactItem>
                                    <groupId>org.webjars</groupId>
                                    <artifactId>bootstrap</artifactId>
                                    <version>3.3.6</version>
                                    <type>jar</type>
                                    <includes>
                                        META-INF/resources/webjars/bootstrap/*/css/*.css,
                                        META-INF/resources/webjars/bootstrap/*/css/*.map,
                                        META-INF/resources/webjars/bootstrap/*/js/*.js,
                                        META-INF/resources/webjars/bootstrap/*/js/*.map
                                    </includes>
                                    <fileMappers>
                                        <org.codehaus.plexus.components.io.filemappers.RegExpFileMapper>
                                            <pattern>
                                                ^META-INF/resources/webjars/bootstrap/[^/]+/</pattern>
                                            <replacement>./</replacement>
                                        </org.codehaus.plexus.components.io.filemappers.RegExpFileMapper>
                                    </fileMappers>
                                    <outputDirectory>
                                        target/${project.artifactId}-${project.version}/webjars/bootstrap3.3.6/</outputDirectory>
                                </artifactItem>

URLs:
Bootstrao5 - http://localhost:8080/vivo/webjars/bootstrap/css/bootstrap.css
Bootstrao3 - http://localhost:8080/vivo/webjars/bootstrap3.3.6/css/bootstrap.css

@chenejac chenejac removed the stacked label Oct 8, 2024
@litvinovg litvinovg force-pushed the bootstrap5-dependency branch from 9605af0 to d2c1da4 Compare December 3, 2024 15:43
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants