-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap5 dependency #467
base: main
Are you sure you want to change the base?
Conversation
f7e07e3
to
9605af0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
Just to note, I tried to add multiple versions of Bootstrap to the project by duplicating the section, and changing the and elements. Like this:
URLs: |
9605af0
to
d2c1da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
What does this pull request do?
Added Boostrap 5 webjar dependency. Only the last commit related to this PR.
How should this be tested?
Build Vitro and VIVO
Interested parties
@milospp @chenejac
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed