-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch 7.* and 8.* integration. OpenSearch integration. #469
base: main
Are you sure you want to change the base?
Elasticsearch 7.* and 8.* integration. OpenSearch integration. #469
Conversation
…entation and configuration mechanisms.
…-side service detection mechanism.
The following features should be tested:
|
@ivanmrsulja please create a VIVO PR with updated example.runtime.properties. Also, please move JSON configuration into vivo-es project. Add in the vivo-es project a Docker file, and update README file to explain how ES should be run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanmrsulja basic VIVO search functionalities works for me. I didn't review the code. Instructions from the PR description about setup of the elasticsearch index might be replaced with a pointer to the vivo-es Readme file.
What does this pull request do?
Updates current ES 6.x integration to 8.x.
What's new?
Changes in ResponseParser and ES documentation on the first draft.
Example:
src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/elasticsearch/ResponseParser.java
to be in line with current ES APIsrc/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/elasticsearch/Elasticsearch_notes_on_the_first_draft.md
with new mappingHow should this be tested?
Initial setup
{vitro_home}/config/applicationSetup.n3
to use this driver (see below).vitro.local.searchengine.url
configuration property to contain ES index base URL (due to backward compatibility, Solr can also be configured usingvitro.local.solr.url
. This will however result in a warning that is shown in logs, advising the client to switch to a new configuration parameter)vitro.local.searchengine.username
configuration property to contain ES/OS basic auth usernamevitro.local.searchengine.password
configuration property to contain to contain ES/OS basic auth passwordA mapping for the search index
Modify
applicationSetup.n3
Your setup should be completed now 😃 ! After this, you should perform common manual tests that are done for every new release.
Interested parties
@chenejac
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises: