Custom context path configuation option #475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Oct 28, 2024
There was a problem hiding this comment.
@litvinovg I have left two tiny comments. Please, also invest whether edu/cornell/mannlib/vitro/webapp/filters/PageRoutingFilter.java should be updated as well.
.../main/java/edu/cornell/mannlib/vitro/webapp/controller/freemarker/ContactFormController.java
Outdated
Show resolved
Hide resolved
...ain/java/edu/cornell/mannlib/vitro/webapp/freemarker/config/FreemarkerConfigurationImpl.java
Outdated
Show resolved
Hide resolved
I think PageRoutingFilter shouldn't be changed. |
chenejac
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: (please link to issue)
VIVO PR
What does this pull request do?
These new configuration options allow you to create correct links when the application is behind a proxy server, thus minimizing the required redirects.
What's new?
Added configuration option to modify context path in case when the application is behind proxy.
Replaced calls for context path to utility methods that allow overriding default context path.
How should this be tested?
Default behavior when configuration property is not set should be the same.
To test application behind proxy one would need to configure webserver and tomcat in proxy mode like described in workaround of linked issue.
#Additional notes
Interested parties
@VIVO-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed