chore: update snap for Tauri #120
Annotations
13 warnings
useless conversion to the same type: `std::string::String`:
src/slugify.rs#L38
warning: useless conversion to the same type: `std::string::String`
--> src/slugify.rs:38:9
|
38 | / match *i {
39 | | 0 => anchor,
40 | | i => format!("{}-{}", anchor, i),
41 | | }
42 | | .into()
| |_______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into()`
|
38 ~ match *i {
39 + 0 => anchor,
40 + i => format!("{}-{}", anchor, i),
41 + }
|
|
this function has too many arguments (8/7):
src/post.rs#L141
warning: this function has too many arguments (8/7)
--> src/post.rs:141:5
|
141 | / pub fn new(
142 | | front_matter: FrontMatter,
143 | | excerpt: Option<String>,
144 | | content: String,
... |
149 | | ancestor_directories_names: Vec<String>,
150 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/content.rs#L461
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/content.rs:461:5
|
461 | / match front_matter {
462 | | Some(front_matter) => {
463 | | if encoded {
464 | | url_path.push(byte_serialize(front_matter.slug.as_bytes()).collect::<String>())
... |
469 | | None => (),
470 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
461 ~ if let Some(front_matter) = front_matter {
462 + if encoded {
463 + url_path.push(byte_serialize(front_matter.slug.as_bytes()).collect::<String>())
464 + } else {
465 + url_path.push(&front_matter.slug)
466 + }
467 ~ };
|
|
comparison to empty slice:
src/content.rs#L241
warning: comparison to empty slice
--> src/content.rs:241:20
|
241 | if dir_index != "" {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dir_index.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
= note: `#[warn(clippy::comparison_to_empty)]` on by default
|
the following explicit lifetimes could be elided: 'a:
src/content.rs#L214
warning: the following explicit lifetimes could be elided: 'a
--> src/content.rs:214:27
|
214 | pub fn get_posts_per_tags<'a>(posts: &'a [Post]) -> HashMap<String, Vec<&'a Post>> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
214 - pub fn get_posts_per_tags<'a>(posts: &'a [Post]) -> HashMap<String, Vec<&'a Post>> {
214 + pub fn get_posts_per_tags(posts: &[Post]) -> HashMap<String, Vec<&Post>> {
|
|
unnecessary use of `to_string`:
src/content.rs#L205
warning: unnecessary use of `to_string`
--> src/content.rs:205:21
|
205 | slugify(tag.to_string())
| ^^^^^^^^^^^^^^^ help: use: `tag`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
= note: `#[warn(clippy::unnecessary_to_owned)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L142
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:142:13
|
142 | &post,
| ^^^^^ help: change this to: `post`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L73
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:73:9
|
73 | &site.settings.website_title.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.website_title.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L72
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:72:9
|
72 | &site.settings.author.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.author.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L71
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:71:9
|
71 | &site.settings.base_url.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.base_url.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L65
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:65:9
|
65 | &site.settings.base_url.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.base_url.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this `if` statement can be collapsed:
src/content.rs#L241
warning: this `if` statement can be collapsed
--> src/content.rs:241:17
|
241 | / if dir_index != "" {
242 | | if site
243 | | .settings
244 | | .create_index_for
... |
250 | | }
251 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
241 ~ if dir_index != "" && site
242 + .settings
243 + .create_index_for
244 + .contains(&dir_index.to_string()) {
245 + let key = dir_index.to_string();
246 + let posts = indexes_to_create.entry(key).or_default();
247 + posts.push(post);
248 + }
|
|
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|