Extract methods for readability

Signed-off-by: Jakub Zalas <[email protected]>
vlingo · Dec 14, 2021 · 6223e4b · 6223e4b
1 parent 780c3cc
commit 6223e4b
Showing 1 changed file with 23 additions and 20 deletions.
diff --git a/...ain/java/io/vlingo/xoom/actors/plugin/mailbox/concurrentqueue/ConcurrentQueueMailbox.java b/...ain/java/io/vlingo/xoom/actors/plugin/mailbox/concurrentqueue/ConcurrentQueueMailbox.java
@@ -50,11 +50,7 @@ public void resume(final String name) {
 
   @Override
   public void send(final Message message) {
-    if (isSuspendedExceptFor(message)) {
-      suspendedDeliveryQueue.get().add(message);
-    } else {
-      queue.add(message);
-    }
+    queue(message);
     if (!isDelivering()) {
       dispatcher.execute(this);
     }
@@ -82,7 +78,11 @@ private boolean isSuspendedExceptFor(final Message override) {
 
   @Override
   public Message receive() {
-    return queue.poll();
+    if (!isSuspended()) {
+      return queue.poll();
+    } else {
+      return suspendedDeliveryQueue.get().poll();
+    }
   }
 
   @Override
@@ -95,24 +95,15 @@ public void run() {
     if (delivering.compareAndSet(false, true)) {
       final int total = throttlingCount;
       for (int count = 0; count < total; ++count) {
-        if (isSuspended()) {
-          Message message = suspendedDeliveryQueue.get().poll();
-          if (message != null) {
-            message.deliver();
-          } else {
-            break;
-          }
+        final Message message = receive();
+        if (message != null) {
+          message.deliver();
         } else {
-          final Message message = receive();
-          if (message != null) {
-            message.deliver();
-          } else {
-            break;
-          }
+          break;
         }
       }
       delivering.set(false);
-      if (!queue.isEmpty() || !suspendedDeliveryQueue.get().isEmpty()) {
+      if (!isQueueEmpty()) {
         dispatcher.execute(this);
       }
     }
@@ -124,6 +115,18 @@ public int pendingMessages() {
     return queue.size();
   }
 
+  private void queue(final Message message) {
+    if (isSuspendedExceptFor(message)) {
+      suspendedDeliveryQueue.get().add(message);
+    } else {
+      queue.add(message);
+    }
+  }
+
+  private boolean isQueueEmpty() {
+    return queue.isEmpty() && suspendedDeliveryQueue.get().isEmpty();
+  }
+
   protected ConcurrentQueueMailbox(final Dispatcher dispatcher, final int throttlingCount) {
     this.dispatcher = dispatcher;
     this.delivering = new AtomicBoolean(false);