[2/n][pipeline-gen] Convert default values into constant vars #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
khluu
commented
Sep 28, 2024
•
khluu
commented
- Convert all default values used in plugin config into constant vars so it's easier to test
Signed-off-by: kevin <[email protected]>
aslonnie
reviewed
Sep 30, 2024
scripts/pipeline_generator/plugin.py
Outdated
| @@ -88,6 +95,7 @@ class KubernetesPluginConfig(BaseModel): | |||
|
|
|||
|
|
|||
| def get_kubernetes_plugin_config(container_image: str, test_bash_command: List[str], num_gpus: int) -> Dict: | |||
| test_bash_command[-1] = f'"{test_bash_command[-1]}"' | |||
There was a problem hiding this comment.
what is this line doing?
There was a problem hiding this comment.
is this for the quoting? why is this required? this is going to be prone to env var injection?
| @@ -20,7 +20,7 @@ def test_get_kubernetes_plugin_config(): | |||
| "containers": [ | |||
| { | |||
| "image": docker_image_path, | |||
| "command": [" ".join(test_bash_command)], | |||
| "command": ['bash -c "echo A"'], | |||
There was a problem hiding this comment.
I do not quite understand the change in this file.
aslonnie
reviewed
Sep 30, 2024
Signed-off-by: kevin <[email protected]>
|
I just removed the quote thing from this PR |
aslonnie
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.