Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][Frontend] Update Llama 3.2 Chat Template to support Vision and Non-Tool use #10164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+65 −20
Open

[Bugfix][Frontend] Update Llama 3.2 Chat Template to support Vision and Non-Tool use #10164

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a05f01
update llama 3.2 chat template
tjohnson31415 Nov 7, 2024
f75e461
remove 'is iterable' check when rendering a tool response
tjohnson31415 Nov 11, 2024
806db87
support system prompt with object content
tjohnson31415 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions examples/tool_chat_template_llama3.2_json.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@

{#- This block extracts the system message, so we can slot it into the right place. #}
{%- if messages[0]['role'] == 'system' %}
{%- set system_message = messages[0]['content']|trim %}
{%- if messages[0]['content'] is string %}
{%- set system_message = messages[0]['content']|trim %}
{%- else %}
{#- Support vLLM's transforming of a content string to JSON. #}
{%- set system_message = messages[0]['content'][0]['text']|trim %}
{%- endif %}
{%- set messages = messages[1:] %}
{%- else %}
{%- if tools is not none %}
Expand Down Expand Up @@ -120,7 +125,7 @@
{{- "<|eot_id|>" }}
{%- elif message.role == "tool" or message.role == "ipython" %}
{{- "<|start_header_id|>ipython<|end_header_id|>\n\n" }}
{%- if message.content is mapping or message.content is iterable %}
{%- if message.content is mapping %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can invert the condition? i.e. check whether it is a string like in L32

{{- message.content | tojson }}
{%- else %}
{{- { "output": message.content } | tojson }}
Expand Down