Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Update benchmark to support image_url file or http #10287

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

kakao-steve-ai
Copy link
Contributor

@kakao-steve-ai kakao-steve-ai commented Nov 13, 2024

For testing ShareGPT4V dataset in benchmarks/benchmark_serving.py, the part setting image_url was updated slightly.

Client Usage:

python3 benchmarks/benchmark_serving.py --backend openai-chat \
    --base-url http://127.0.0.1:8000/v1 \
    --endpoint /chat/completions \
    --model llava-hf/llava-v1.6-mistral-7b-hf \
    --dataset-path Lin-Chen/ShareGPT4V \
    --dataset-name hf --hf-subset ShareGPT4V \
    --hf-split train \
    --num-prompts=100

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @lk-chen

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2024
@DarkLight1337 DarkLight1337 merged commit 8b6725b into vllm-project:main Nov 16, 2024
40 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants