Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Enable proxy support in benchmark script #12356

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsato8094
Copy link
Contributor

@jsato8094 jsato8094 commented Jan 23, 2025

This PR allows the benchmark script to respect HTTP proxy settings specified through environment variables. This is particularly useful when running the script in environments where network access requires proxy configurations. The trust_env=True parameter instructs aiohttp to use proxy settings from environment variables such as HTTP_PROXY and HTTPS_PROXY.

For more details on proxy support in aiohttp, refer to the official documentation: Proxy Support in aiohttp.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jsato8094 jsato8094 force-pushed the benchmark_session_trust_env_true branch from cce6047 to 448e260 Compare January 23, 2025 13:23
Signed-off-by: Junichi Sato <[email protected]>
Signed-off-by: Junichi Sato <[email protected]>
@jsato8094 jsato8094 force-pushed the benchmark_session_trust_env_true branch from fb7e905 to acd5eaf Compare January 23, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant