This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Allow admin email and password to be overridden (fixes #369) #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds handling of ADMIN_EMAIL and ADMIN_PASSWORD env vars to deploy scripts - Supersedes #368 - Documents HEROKU_REGION env var - Documents issue identified in #346
dwettstein
referenced
this pull request
in dwettstein/postfacto
Dec 15, 2021
* master: Bump nokogiri from 1.11.3 to 1.11.4 in /e2e (#386) Bump nokogiri from 1.11.3 to 1.11.4 in /api (#387) Bump ExecJS version Upgrade Rails to 6.1.3.2 (#382) [Snyk] Security upgrade puma from 5.2.2 to 5.3.1 (#381) Upgrade web dependencies (#377) Fix conditional push of Docker containers Fix typo in CI workflow Allow creation of sharable retro from admin panel (fixes #308) (#376) Overhaul Docker build, push and test (#375) Explicitly push all tags Fix the Docker push scripts (#373) Allow admin email and password to be overridden (fixes #369) (#371) Improve CONTRIBUTING.md formatting (#367) [skip ci] fix: upgrade mixpanel-browser from 2.39.0 to 2.41.0 (#364) fix: upgrade actioncable from 5.2.4 to 5.2.5 (#365) Remove broken gitter link (fixes #350) [skip ci] RFC - Attempt at making deployment docs easier to follow (#313) Migrate from Travis to GitHub Actions (#363) Upgrade all the things (#360)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
ADMIN_EMAILandADMIN_PASSWORDenv vars to deploy scriptsHEROKU_REGIONenv varAn explanation of the use cases your change solves
Allows a more secure Postfacto installation by allowing the user to override the default admin credentials rather than have to reset them once installed.
Links to any other associated PRs
I have reviewed the contributing guide
I have made this pull request to the
masterbranchI have run all the tests using
./test.sh.I have added the copyright headers to each new file added
I have given myself credit in the humans.txt file (assuming I want to)