Support setting fs-dir for fs datasource #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a control plane meltdown when starting KFO on a GKE cluster with 1000s of nodes as reloader will make several kube api calls at the same time when DaemonSet pods start at the same time. In order to mitigate this issue we are planning to go with
fs
datasource with configs read from a volume mount. But the current helm chart doesn't have an option to set required--fs-dir
arg whendatasource: fs
is used. This PR is to add an option to setfs-dir
in helm so that we can usefs
datasoiurce.