Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting fs-dir for fs datasource #449

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jeesmon
Copy link
Contributor

@jeesmon jeesmon commented Nov 8, 2024

We had a control plane meltdown when starting KFO on a GKE cluster with 1000s of nodes as reloader will make several kube api calls at the same time when DaemonSet pods start at the same time. In order to mitigate this issue we are planning to go with fs datasource with configs read from a volume mount. But the current helm chart doesn't have an option to set required --fs-dir arg when datasource: fs is used. This PR is to add an option to set fs-dir in helm so that we can use fs datasoiurce.

@vmwclabot
Copy link
Member

@jeesmon, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@jeesmon
Copy link
Contributor Author

jeesmon commented Nov 8, 2024

@luisdavim Can you please review? Thanks!

Copy link
Contributor

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@luisdavim luisdavim merged commit 377758c into vmware:main Nov 8, 2024
1 check passed
@jeesmon jeesmon deleted the datasource_fs branch November 13, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants