Avoid recreating gateway when locale service added #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
approved these changes
Jan 26, 2025
|
/test-all |
2 similar comments
|
/test-all |
|
/test-all |
This change removes ForceNew from nsx_id attribute in locale service schema, in order to avoid recreating the gateway when locale service is added. Without this fix, adding locale_service within the gateway would trigger recreation even when nsx_id is not specified, since nsx_is is defined as Computed. Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
no-forcenew-in-locale-service
branch
from
f78fc4d to
29c873e
Compare
|
/test-all |
ksamoray
approved these changes
Jan 28, 2025
|
We need to add an update test with interfaces present - not merging this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes ForceNew from nsx_id attribute in locale service schema, in order to avoid recreating the gateway when locale service is added.
Without this fix, adding locale_service within the gateway would trigger recreation even when nsx_id is not specified, since nsx_is is defined as Computed.