fix: check return value of d.Set
#276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacegospod
approved these changes
Oct 28, 2024
Yeah, a bit of a pain. |
tenthirtyam
force-pushed
the
fix/check-return-valude
branch
from
39a985b
to
4046556
Compare
tenthirtyam
force-pushed
the
fix/check-return-valude
branch
2 times, most recently
from
afbb38b
to
0365272
Compare
Resolves all instances of "return value of `d.Set` is not checked" from `errcheck`. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
fix/check-return-valude
branch
from
0365272
to
5dc05ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Resolves all instances of "return value of
d.Setis not checked" fromerrcheck.Example returned in the
golangci-lintaction.Type of Pull Request
Please describe:
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
For bug fixes or features:
Breaking Changes?