Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sample POM implementation #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahmed-abdurrahman
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@developer-vngrs
Copy link

Messages
📖 These files have changed: Movies.xcodeproj/project.pbxproj, Movies/Common/ViewController.swift, Movies/Screens/Movies/Movies List/Cells/MovieTableViewCell.swift, Movies/Screens/Movies/Movies List/MoviesListViewController.swift, MoviesUITests/BaseTests.swift, MoviesUITests/Tests/HomePageTests.swift, MoviesUITests/Tests/MoviesLaunchPerformanceTests.swift, MoviesUITests/POM/Base/Page.swift, MoviesUITests/POM/Base/UIElement.swift, MoviesUITests/POM/Base/UIElementPage.swift, MoviesUITests/POM/Base/UITestablePage.swift, MoviesUITests/POM/Pages/POMHomePage.swift, MoviesUITests/POM/Tests/POMHomeTests.swift, MoviesUITests/POM/UIElements.swift

SwiftLint found issues

Severity File Reason
Warning POMHomeTests.swift:9 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning UIElements.swift:21 MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)
Warning MovieTableViewCell.swift:49 Lines should not have trailing whitespace. (trailing_whitespace)
Warning BaseTests.swift:22 Lines should not have trailing whitespace. (trailing_whitespace)
Warning MoviesListViewController.swift:34 Lines should not have trailing whitespace. (trailing_whitespace)
Warning MoviesLaunchPerformanceTests.swift:9 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

Generated by 🚫 Danger Swift against 22fe314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants