Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Gen #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Swift Gen #33

wants to merge 2 commits into from

Conversation

obadasemary
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

No Coverage information No Coverage information
13.8% 13.8% Duplication

@developer-vngrs
Copy link

Messages
📖 These files have changed: Movies.xcodeproj/project.pbxproj, Movies/Screens/MainTabBar/TabBarController.swift, Movies/Screens/Movies/Movies List/Cells/MovieTableViewCell.swift, Podfile, Podfile.lock, Assets.swift, Colors.swift, Movies/Resources/Assets.xcassets/LightGreen.colorset/Contents.json, Movies/Resources/colors.txt, MoviesUITests/Pages/HomePage 2.swift, swiftgen.yml

SwiftLint found issues

Severity File Reason
Warning HomePage 2.swift:20 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning HomePage 2.swift:44 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning MovieTableViewCell.swift:49 Lines should not have trailing whitespace. (trailing_whitespace)
Warning TabBarController.swift:83 Variable name should be between 3 and 40 characters long: 'vc' (identifier_name)
Warning TabBarController.swift:117 TODOs should be resolved (add controller specific logic ...). (todo)

Generated by 🚫 Danger Swift against dacdd4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants