Update Rails 7.2 #744
Merged
Update Rails 7.2 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manno
commented
Oct 3, 2024
•
manno
commented
- do links in feeds work?
- needs ruby 3.3 on server
- graphql conference resolver updated
- active admin might be restricted due to ransack 4, needs allow list entries
- database dump not running on prod since 37c3
- removes .envrc and .bundle/config from git, update your setups
- redis cache expiry still working? (switch to memcached maybe, but sidekiq still using redis..)
This needs to match activeadmin filters.
* Removing asdf instruction from .envrc, fails for non-asdf users * Skipping elasticsearch by default * Loosen rubocop linters, too many warnings, too many rules. Not enough people and tools following them.
Resolvers parameters changed a few years ago. Thiss should be converted into a plain ruby class? https://graphql-ruby.org/fields/resolvers.html ``` ConferencesGraphQLApiTest#test_load_newest_conference: ArgumentError: wrong number of arguments (given 1, expected 3) app/graphql/resolvers/conference.rb:63:in `resolve' test/integration/graphql/conferences_test.rb:64:in `block in <class:ConferencesGraphQLApiTest>' ``` Anyhow, this passes tests.
Tests pass 🤷
* Needs access to gems in development group * Update ruby to minimum for 7.2
Re-using the DEV_DOMAIN env var which is used to initialize allowed dns names via config.hosts Also prod static image URL changed to include /media.
* no more lograge, log to stdout by default
This will likely break urls in all feeds.
We'll fix those "todos" "later".
Those are custom per developer
It's not compatible with sassc `RAILS_ENV=production rake assets:precompile` rmosolgo/graphiql-rails#120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.