Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement edit profile screen #777

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Implement edit profile screen #777

merged 6 commits into from
Oct 3, 2024

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Sep 30, 2024

A new view for profile editing.

It also does a refactor of the dashboard layout to allow scrolling while keeping the background always visible.

@selankon editions:

  • Moved the src/components/OrganizationSaas/Dashboard/EditProfile.tsx into src/components/AccountSaas/EditProfile.tsx
  • Created a src/components/AccountSaas/Layout.tsx to share inputs between forms
  • Same by shared types, created src/components/AccountSaas/AccountTypes.ts
  • It implements the EditProfile page on elements folder

Copy link

github-actions bot commented Sep 30, 2024

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 10:41 Inactive
Copy link

github-actions bot commented Sep 30, 2024

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 10:41 Inactive
Copy link
Contributor

@selankon selankon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of logic that is copy pasted from src/components/Account/EditProfile.tsx and should not. We have to apply the principle of DRY (Dont Repeat Yourself) as much as possible.

src/components/Layout/SaasSelector.tsx Outdated Show resolved Hide resolved
src/components/OrganizationSaas/Dashboard/EditProfile.tsx Outdated Show resolved Hide resolved
src/components/OrganizationSaas/Dashboard/EditProfile.tsx Outdated Show resolved Hide resolved
src/components/OrganizationSaas/Dashboard/EditProfile.tsx Outdated Show resolved Hide resolved
src/components/OrganizationSaas/Dashboard/EditProfile.tsx Outdated Show resolved Hide resolved
src/components/OrganizationSaas/Dashboard/EditProfile.tsx Outdated Show resolved Hide resolved
src/components/OrganizationSaas/Dashboard/EditProfile.tsx Outdated Show resolved Hide resolved
@selankon selankon changed the title edit profile Implement edit profile screen Oct 1, 2024
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 09:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 09:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 10:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 10:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 11:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 11:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 11:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 11:15 Inactive
@selankon selankon marked this pull request as draft October 1, 2024 12:37
@selankon selankon marked this pull request as ready for review October 1, 2024 13:02
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 07:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 07:21 Inactive
@selankon selankon merged commit d90b806 into d/saas Oct 3, 2024
3 checks passed
@selankon selankon deleted the f/edit-profile branch October 3, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants