-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement edit profile screen #777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of logic that is copy pasted from src/components/Account/EditProfile.tsx
and should not. We have to apply the principle of DRY (Dont Repeat Yourself) as much as possible.
selankon
force-pushed
the
f/edit-profile
branch
from
October 1, 2024 09:32
c4c283c
to
db5cf50
Compare
selankon
force-pushed
the
f/edit-profile
branch
from
October 1, 2024 11:07
31b0ad5
to
3e96495
Compare
selankon
approved these changes
Oct 1, 2024
selankon
force-pushed
the
f/edit-profile
branch
from
October 1, 2024 14:43
4abdc66
to
3c0e01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new view for profile editing.
It also does a refactor of the dashboard layout to allow scrolling while keeping the background always visible.
@selankon editions:
src/components/OrganizationSaas/Dashboard/EditProfile.tsx
intosrc/components/AccountSaas/EditProfile.tsx
src/components/AccountSaas/Layout.tsx
to share inputs between formssrc/components/AccountSaas/AccountTypes.ts
elements
folder